Fix StreamingDataset len after drop_last update#778
Conversation
MagellaX
requested review from
justusschock,
lantiga and
tchaton
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685611 | Triggered | Generic High Entropy Secret | 702ae1c | tests/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
===================================
- Coverage 80% 80% -0%
===================================
Files 52 52
Lines 7362 7366 +4
===================================
+ Hits 5906 5907 +1
- Misses 1456 1459 +3 🚀 New features to boost your workflow:
|
…tion - Add enhanced docstrings to set_shuffle() and set_drop_last() explaining cache invalidation rationale - Clarify that shuffler is invalidated to ensure length calculations reflect parameter changes - Update inline comments to explain why shuffler reset is necessary - Simplify test docstring per repo conventions - Add explicit assertion for expected batch count in test_len_called_before_dataloader_drop_last - Ensures developer clarity on cache invalidation behavior
|
it's all good to merge!! |
|
pls merge it, so i can later delete this branch!! |
3 participants
Before submitting
What does this PR do?
Fixes #772.