Skip to content

[react] add library managed attributes and upgrade TS requirement to 2.8#27901

Merged
johnnyreilly merged 3 commits into
DefinitelyTyped:masterfrom
ferdaber:react-library-managed-attributes
Aug 6, 2018
Merged

[react] add library managed attributes and upgrade TS requirement to 2.8#27901
johnnyreilly merged 3 commits into
DefinitelyTyped:masterfrom
ferdaber:react-library-managed-attributes

Conversation

@ferdaber

@ferdaber ferdaber commented Aug 6, 2018

Copy link
Copy Markdown
Contributor
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes.
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

Final part of our saga. Thank you all for your patience!

@ferdaber ferdaber requested a review from johnnyreilly as a code owner August 6, 2018 14:21
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Aug 6, 2018
@typescript-bot

typescript-bot commented Aug 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@ferdaber Thank you for submitting this PR!

🔔 @jgoz @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @johnnyreilly @theruther4d @guilhermehubner @jrakotoharisoa @pascaloliv @Hotell @MartynasZilinskas @bgrieder @cdroulers @gyzerok @tillwolff @LKay @bhouser @kristerkari @formatlos @shuntksh @Hesquibet @giladgray @iebaker @skirsdeda @vujevits @devrelm @onatm @ninjaferret @tehbi4 @misantronic @darkartur @arvitaly @lochbrunner @iskandersierra @mrapogee @clayne11 @Pajn @lucasterra - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

typescript-bot commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

@ferdaber The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@johnnyreilly johnnyreilly merged commit 1d9679b into DefinitelyTyped:master Aug 6, 2018
@ferdaber

ferdaber commented Aug 6, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for enduring the wait, and thanks to the TypeScript team for offering their valuable insight and assistance in getting this to completion!

briandk pushed a commit to briandk/DefinitelyTyped that referenced this pull request Aug 7, 2018
@ferdaber @briandk
[react] add library managed attributes and upgrade TS requirement to …
ebdae51 
…2.8 (DefinitelyTyped#27901)

* feat(react): add library managed attributes and upgrade to 2.8

* fix broken tests

* fix lint errors
@cdeutsch cdeutsch mentioned this pull request Aug 8, 2018
Closed
@bernardobelchior

bernardobelchior commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Great work! This has been really useful for me. How can I contribute?
I'm asking because I think I found some missing types, like rawErrors in WidgetProps.

@johnnyreilly

johnnyreilly commented Aug 28, 2018

Copy link
Copy Markdown
Member

How can I contribute?

The answer is always: submit a PR 😋

Help always gratefully received!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnyreilly johnnyreilly Awaiting requested review from johnnyreilly johnnyreilly is a code owner

Assignees

No one assigned

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferdaber @typescript-bot @bernardobelchior @johnnyreilly