[react] update packages to TS 2.8 and add library managed attributes#27482
[react] update packages to TS 2.8 and add library managed attributes#27482ferdaber wants to merge 22 commits into
Conversation
|
cc @weswigham |
|
@ferdaber Thank you for submitting this PR! 🔔 @Shearerbeard @asvetliakov @seryl @dijimsta @lstanden @me @jgoz @Asana @vsiao @dmitryrogozhny @eelco @ghotiphud @schwers @michael-yx-wu @willisplummer @smvilar @sulf @Kovensky @MarianPalkus @NoHomey @jwbay @huhuanming @MartynasZilinskas @thovden @Hotell @tkrotoff @nali @knegusen @joscha @KonstantinKai @martynaskadisa @janaagaard75 @ssanchezmarc @fhelwanger @umidbekkarimov @tinaroh @moshfeu @prokopcm @binki @incleaf @pepaar @stephenjelfs @ilivit @stkb @GiedriusGrabauskas @xbIm @mrk21 @honzabrecka @antonvasin @vittorio @lhache @steller @dborysov @bolatovumar @dawnmist @DovydasNavickas @joshuakgoldberg @coding2012 @samuelneff @grahammendick @dru89 @brikou @jthegedus @resir014 @scottdj92 @joaovieira @Romic @khanhas @Slessi @mleko @alexgorbatchev @nupplaphil @mihe @DenisTirilis @mantasmarcinkus @mattoni @paustint @j-fro @johnnyreilly @Methuselah96 @ssyrell @endigo @ralbuque @prakarshpandey @forabi @crohlfs @nicolas-schmitt @pjo256 @robessog @tbayne @cdeutsch @rosskevin @diogocorrea @gabsprates @varHarrie @bradleyayers @marknelissen @piotrwitek @pikpok @eps1lon @mhegazy @LKay @ssi-hu-antal-bodnar @ianks @flaub @alelode @UJosue10 @Ogglas @Guymestef @radziksh @PaitoAnderson @KostyaEsmukov @mitsuruog @kandros @9renpoto @acemac @trevonmckay @screendriver @velveret @rudi-c @Kimahriman @markspolakovs @mntdn @santiagodoldan @alaatm @samwalshnz @mabels @BernabeFelix @vstrimaitis @stepancar @skirsdeda @David-LeBlanc-git @kittimiyo @SupernaviX @KieranPeat @martinnov92 @Junbong @andrewBalekha @smrq @Rogach @royxue @KoalaHuman @seansfkelley @uncovertruth @ArturAmpilogov @NathanNZ @Sa-ryong @oizie @gustavohenke @cleverguy25 @theruther4d @matdube @LynxEyes @goblindegook @benbayard @codeaid @jurosh @eugrdn @danzel @patsissons @apare @jankarres @alitaheri @senukartur @begincalendar @pushplay @timurrustamov @dublicator @vincaslt @gavingregory @cameron-mcateer @TiuSh @jsonunger @brmenchl @vasilysn @invliD @abirkholz @ZheyangSong @andrewhathaway @grzesie2k @evanbb @isman-usoh @lith-light-g @sammkj @yuit @diogodca @tock203 @chnoch @beheh @danielasy @adamwpc @rhysd @christianchown @sroy3 @Lapanti @psrebniak @bgrieder @cdroulers @gyzerok @tillwolff @bhouser @kristerkari @formatlos @AviVahl @DanielRosenwasser @bendxn @netoisc @spielc @gnestor @iamdanfox @sirreal @iplus26 @KurtPreston @phbou72 @LucianBuzzo @m0a @benjaminRomano @buptyyf @tomshen @odensc @tlaziuk @iMobs @artfuldev @osdiab @rimig @lavoaster @CarlosBonetti @morphologue @bradzacher @marcfallows @tkqubo @drewnoakes @homburg @ttamminen @hallowatcher @peterblazejewicz @dimitarnestorov @alloy @iRoachie @timwangdev @kamal @nelyousfi @alexdunne @swissmanu @bm-software @a-tarasyuk @ifiokjr @RodrigoAWeber @jacobbaskin @MrLuje @jnbt @suniahk @jmfirth @pocesar @josephroque @VincentLanglet @mindhivefi @connectdotz @plantain-00 @mrand01 @CaiHuan @egorshulga @SahinVardar @gazaret @sivolobov @RookY2K @mhcgrq @kaoDev @fangpenlin @petejkim @phanalpha @charlesfamu @bang88 @svbutko @levito @robertohuertasm @YourGamesBeOver @ArmandoAssuncao @cliedeman @magrinj @TizioFittizio @stigi @DeividasBakanas @sztobar @klaascuvelier @heatherbooker @salim7 @jemmyw @aaronbeall @vitosamson @tbounsiar @igorissen @KennethanCeyer @deevus @wouterhardeman @pegel03 @archy-bold @guilhermehubner @r3nya @istefo @mdibyo @jacoporicare @shuntksh @aghoneim92 @zzanol @thasner @kenzierocks @clayne11 @tansongyang @nicholasboll @pdeva @kallikrein @val1984 @jrakotoharisoa @clementdevos @graphcool @voxmatt @npirotte @ckknight @matthew-matvei @aMoniker @alechill @xaviergonz @Ragg- @fsubal @sergey-buturlakin @vasek17 @ngbrown @awendland @ssorallen @huy-nguyen @grmiade @DaIgeb @neuoy @rraina @pret-a-porter @t49tran @sudoplz @Hesquibet @giladgray @iebaker @vujevits @devrelm @onatm @ninjaferret @tehbi4 @misantronic @darkartur @icopp @naortor @remojansen @jeroenvervaeke @ricokahler @DomiR @charlesrey @pelotom @curtisw0 @jbraithwaite @dan-j @sonnysangha @9y5 @thchia @viccrubs @chrisgarber @kiyopikko @mctep @horiuchi @mxl @psakalo @Havret @danez @matthewberryman @wassname @mykter @arvitaly @lochbrunner @ryprice @cavarzan @zry656565 @kerwynrg - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@ferdaber The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@johnnyreilly Travis is failing due to the number of packages changed. The tests are causing an out-of-memory error. |
|
Hmmm not sure what to suggest; this is presumably a (regrettable) limitation of our test infrastructure set-up. Is this straightforward to batch up into a number of smaller PRs? Or feel free to tweak our test infrastructure! |
|
Not really. The overwhelming majority of the changes is bumping the minimum version of the typings to TS 2.8 which is a necessary change because of how the dt publisher works. Unless you mean create a bunch of PRs that do nothing besides bumping version to 2.8. |
|
Aye, you can bump the dependent packages in separate PRs to work around the memory issue. |
|
Same issue occurred here #26545 and to solve it we had to increase buffer size microsoft/types-publisher#471 |
|
I can do that. Going by how many tests were successful before the OOM issue occurred I think two PRs should be sufficient (I can test locally for that). Thanks for the suggestions, y'all! |
|
Current Travis CI errors are not related to microsoft/types-publisher#471 (am I missing something here?): |
|
You're right! I was wondering where the recompose errors went... Regardless I'm going to close this PR when I next work on it and split it otherwise I won't be able to see the actual errors before Travis poops the bed. |
|
@ferdaber can we add type StrictifyFunctions<T> = {
[K in keyof T]: T[K] extends (...args: infer A) => infer R
? (...a: A) => R
: T[K] extends Object ? StrictifyFunctions<T[K]> : T[K]
};
..... StrictifyFunctions<Defaultize<TProps, D>>This addes correct variance checking for methods. |
|
@goloveychuk forcing strict variance checking on every react consumer is a big break. I wouldn't do it as the same time as this addition. |
|
@ferdaber I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
@ferdaber To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.Part 2 of this closed PR: #27267. Dependent on #27378.