Skip to content

es6-shim: Avoid conflict with global PropertyKey type#25421

Merged
sheetalkamat merged 1 commit into
masterfrom
es6-shim-property-key
May 7, 2018
Merged

es6-shim: Avoid conflict with global PropertyKey type#25421
sheetalkamat merged 1 commit into
masterfrom
es6-shim-property-key

Conversation

@ghost

@ghost ghost commented Apr 30, 2018

Copy link
Copy Markdown

This is an error in typescript@next since we added a new global type in microsoft/TypeScript#23592.

@typescript-bot

typescript-bot commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

@Andy-MS Thank you for submitting this PR!

🔔 @rbuckton - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label May 5, 2018
@typescript-bot

Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@sheetalkamat sheetalkamat merged commit c38ac7f into master May 7, 2018
@sheetalkamat sheetalkamat deleted the es6-shim-property-key branch May 7, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants