Skip to content

core-js: Comment out dict[sym] test#25420

Merged
sheetalkamat merged 1 commit into
masterfrom
core-js-dict-sym
May 7, 2018
Merged

core-js: Comment out dict[sym] test#25420
sheetalkamat merged 1 commit into
masterfrom
core-js-dict-sym

Conversation

@ghost

@ghost ghost commented Apr 30, 2018

Copy link
Copy Markdown

This doesn't seem to be possible any more due to microsoft/TypeScript#23592 -- we support specific symbol names but not symbol index signatures.

@ghost ghost requested a review from rbuckton as a code owner April 30, 2018 14:52
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 30, 2018
@typescript-bot

typescript-bot commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

@Andy-MS Thank you for submitting this PR!

🔔 @rbuckton @mfdeveloper - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label May 5, 2018
@typescript-bot

Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@sheetalkamat sheetalkamat merged commit d12082b into master May 7, 2018
@sheetalkamat sheetalkamat deleted the core-js-dict-sym branch May 7, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants