Skip to content

pad: Allow to use a string instead of an options object#19208

Merged
1 commit merged into
masterfrom
pad
Aug 28, 2017
Merged

pad: Allow to use a string instead of an options object#19208
1 commit merged into
masterfrom
pad

Conversation

@ghost

@ghost ghost commented Aug 21, 2017

Copy link
Copy Markdown

This was now a compile error thanks to microsoft/TypeScript#16343.

@dt-bot

dt-bot commented Aug 21, 2017

Copy link
Copy Markdown
Member

types/pad/index.d.ts

to author (@mhegazy). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@typescript-bot

Copy link
Copy Markdown
Contributor

@Andy-MS Please fix the failures indicated in the Travis CI log.

@typescript-bot typescript-bot added The Travis CI build failed Revision needed This PR needs code changes before it can be merged. labels Aug 21, 2017
@typescript-bot typescript-bot removed The Travis CI build failed Revision needed This PR needs code changes before it can be merged. labels Aug 21, 2017
@typescript-bot

Copy link
Copy Markdown
Contributor

This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Aug 26, 2017
@ghost ghost merged commit b3f1017 into master Aug 28, 2017
@ghost ghost deleted the pad branch August 28, 2017 14:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants