Skip to content

Fix mongoose-promise and mpromise compatibility#19105

Merged
DanielRosenwasser merged 1 commit into
masterfrom
mongoose-promise
Aug 18, 2017
Merged

Fix mongoose-promise and mpromise compatibility#19105
DanielRosenwasser merged 1 commit into
masterfrom
mongoose-promise

Conversation

@ghost

@ghost ghost commented Aug 17, 2017

Copy link
Copy Markdown

This was giving us errors now due to microsoft/TypeScript#16368.

@ghost ghost requested a review from rbuckton August 17, 2017 21:33
@dt-bot

dt-bot commented Aug 17, 2017

Copy link
Copy Markdown
Member

types/mongoose-promise/index.d.ts

to author (@simonxca). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

types/mpromise/index.d.ts

to author (@sgkim126). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@sgkim126

Copy link
Copy Markdown
Contributor

lgtm

@typescript-bot

Copy link
Copy Markdown
Contributor

Approved by a listed owner. PR appears ready to merge pending express review by a maintainer.

@DanielRosenwasser DanielRosenwasser merged commit 29660a9 into master Aug 18, 2017
@ghost ghost deleted the mongoose-promise branch August 18, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants