Use features from typescript 2.0 in ESTree#10305
Merged
Merged
Conversation
rictic
changed the title
Enables narrowing of types based on doing string literal comparisons with the type field. This makes estree much more natural to use, with fewer casts needed.
Member
|
@RReverser could you review this PR? |
Contributor
|
@rictic Thanks for working on this! One nit: can you please change newly created array types to match Other than that, looks good! |
Contributor
Author
|
Sure thing, moved them all to Thanks for the review! |
| type: "ImportDeclaration"; | ||
| specifiers: (ImportSpecifier|ImportDefaultSpecifier|ImportNamespaceSpecifier)[]; | ||
| specifiers: Array< | ||
| ImportSpecifier | ImportDefaultSpecifier | ImportNamespaceSpecifier>; |
Contributor
There was a problem hiding this comment.
Can you please not break the line here? IMO it would look cleaner on the same one.
Contributor
Author
|
Sure thing, removed the line break. |
Contributor
|
Thanks! @vvakame might want you to squash commits, but LGTM. |
This was referenced Aug 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case 2. Improvement to existing type definition.
Uses discriminated union types to allow type narrowing based on string literal comparisons on the
typefield. This makes ESTree much more natural to use, with fewer casts needed.For example: