Skip to content

Move continuation capture methods from scope to tracer #8371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcculls merged 7 commits into from
Feb 13, 2025
Merged

Move continuation capture methods from scope to tracer #8371

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
31d2847
Remove AgentTracer.capture
mcculls Feb 11, 2025
7610abe
Replace TraceScope.capture() with Tracer.captureActiveSpan()
mcculls Feb 12, 2025
365eb0f
Remove unnecessary delegation
mcculls Feb 12, 2025
035db7f
javadoc
mcculls Feb 12, 2025
b03363c
cleanup
mcculls Feb 12, 2025
a7ada65
Respect async propagation flag
mcculls Feb 12, 2025
815385d
delegate
mcculls Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
javadoc
  • Loading branch information
@mcculls
mcculls committed Feb 12, 2025
commit 035db7ff6d9316963a657bb9bff619b0d3ed5c87
6 changes: 3 additions & 3 deletions dd-trace-api/src/main/java/datadog/trace/context/TraceScope.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ public interface TraceScope extends Closeable {

/**
* @deprecated Replaced by {@link Tracer#captureActiveSpan()}.
* <p>Prevent the currently active trace from reporting until the returned Continuation is
* either activated (and the returned scope is closed), or canceled. Should be called on the
* parent thread.
* <p>Prevent the <strong>currently active trace</strong>, which may differ from this scope
* instance, from reporting until the returned Continuation is either activated (and the
* returned scope is closed), or canceled. Should be called on the parent thread.
* @return Continuation of the active span, no-op continuation if there's no active span.
*/
@Deprecated
Expand Down