Skip to content

improve dev env setup documentation for Windows #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucaspimentel merged 21 commits into from
Feb 5, 2025
Merged

improve dev env setup documentation for Windows #8180

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fbd61ac
add PowerShell scripts for Windows
lucaspimentel Sep 20, 2024
74f22b1
fix typo and remove trailing whitespace in BUILDING.md
lucaspimentel Sep 20, 2024
b48ff09
add more Windows instructions, misc tweaks in BUILDING.md
lucaspimentel Jan 10, 2025
328979f
more changes in BUILDING.md
lucaspimentel Jan 10, 2025
0b4160f
use explicit value for JAVA_HOME instead of "%JAVA_8_HOME%"
lucaspimentel Jan 14, 2025
0265531
Update install-jdks-windows.ps1
lucaspimentel Jan 14, 2025
72d1868
move JDK install powershell script
lucaspimentel Jan 17, 2025
dd63642
update BUILDING.md
lucaspimentel Jan 17, 2025
80671d6
add comments about GraalVM license
lucaspimentel Jan 17, 2025
ac6aeaa
add script descriptions
lucaspimentel Jan 17, 2025
8bc08dd
add comment to explain "omit from toc"
lucaspimentel Jan 28, 2025
b95f372
move "Quick check" up
lucaspimentel Jan 28, 2025
146b0bd
remove Windows install script for now
lucaspimentel Jan 30, 2025
5d19bff
rewrite Windows sections to focus on manual installation
lucaspimentel Jan 30, 2025
e0e97cd
remove toc comments
lucaspimentel Jan 30, 2025
5b293fc
more updates to Windows instructions
lucaspimentel Jan 30, 2025
5d757df
fix formatting
lucaspimentel Jan 30, 2025
076f4aa
simplify collapsible sections
lucaspimentel Jan 30, 2025
edd3667
tweak the "click here" text
lucaspimentel Jan 30, 2025
183c6a1
add GraalVM version
lucaspimentel Feb 5, 2025
05774cd
add GraalVM version
lucaspimentel Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use explicit value for JAVA_HOME instead of "%JAVA_8_HOME%"
  • Loading branch information
@lucaspimentel
lucaspimentel committed Jan 30, 2025
commit 0b4160ff1146353dc9bc9cb36235e5d2f1cc6724
8 changes: 5 additions & 3 deletions install-jdks-windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ foreach ($jdkDir in $jdkDirs) {
$envVarName = "JAVA_${version}_HOME"
Write-Host "ℹ️ Setting $envVarName=$jdkDirFullName"
[System.Environment]::SetEnvironmentVariable($envVarName, $jdkDirFullName, [System.EnvironmentVariableTarget]::User)

if ($version -eq '8') {
Write-Host "ℹ️ Setting JAVA_HOME=$jdkDirFullName"
[System.Environment]::SetEnvironmentVariable('JAVA_HOME', $jdkDirFullName, [System.EnvironmentVariableTarget]::User)
}
}
}

Write-Host 'ℹ️ Setting JAVA_HOME=%JAVA_8_HOME%'
[System.Environment]::SetEnvironmentVariable('JAVA_HOME', '%JAVA_8_HOME%', [System.EnvironmentVariableTarget]::User)