Fix failed step output#6623
Merged
Merged
Conversation
Naktibalda
force-pushed
the
fix-failed-step-output
branch
from
fced048 to
5cbf06f
Compare
Naktibalda
force-pushed
the
fix-failed-step-output
branch
2 times, most recently
from
4399fcc to
f35e969
Compare
Naktibalda
force-pushed
the
fix-failed-step-output
branch
from
f35e969 to
906e386
Compare
Because older versions can't mock __clone(): void methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #5820 and probably many other reports about incorrect failed step output
The problem with
$failedStep = (string)array_shift($this->failedStep);in src/Codeception/Subscriber/Console.php was that all failed steps are added to that array in order of test execution, but errors are printed before failures and order of printing doesn't match order of execution.