Conversation
DABH
approved these changes
Aug 22, 2018
DABH
left a comment
DABH
left a comment
Contributor
There was a problem hiding this comment.
LGTM as long as we are sure to upgrade as many of the dependencies as possible before pushing this release. Excited to get this out!
Member
Author
|
Going to cut a |
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
* [dist] Regenerate package-lock.json * [doc] Begin CHANGELOG for 3.1.0 * Fill out changelog and update colors dependency * Update changelog and upgrade deps (all tests still pass) * Correct a seemingly erroneous test and upgrade to latest mocha * Update split2 and nyc... not trivial to upgrade readable-stream * Final changelog update * Add --exit flag to mocha so pending tests don't wreck Travis runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly bug fixes – special thanks to @DABH to staying active on issues while I was afk the last 6 weeks or so. Will merge once CHANGELOG.md is up-to-date.