Change element.parentNode.removeChild(element) to element.remove()#34071
Merged
Conversation
Contributor
|
Hm instead of using |
Member
|
I actually planned to switch to modern APIs but never got to finish the branch and I can't find it right now. Lines 51 to 53 in b39b665 And so on. :) I'd leave this for a separate PR, though. |
GeoSot
commented
May 22, 2021
GeoSot
force-pushed
the
gs-add-remove-element-helper
branch
2 times, most recently
from
efc5a90 to
1fc3957
Compare
GeoSot
force-pushed
the
gs-add-remove-element-helper
branch
from
1fc3957 to
e8d2e64
Compare
alpadev
approved these changes
May 25, 2021
XhmikosR
changed the title
element.remove() methodelement.parentNode.removeChild(element) to element.remove()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
element.parentNode.removeChild(element)toelement.remove()