Skip to content

Fixes the sauce labs tests by bumping karma-sauce-launcher#3813

Merged
jasonsaayman merged 1 commit into
axios:masterfrom
anglinb:bump-sauce-labs
May 27, 2021
Merged

Fixes the sauce labs tests by bumping karma-sauce-launcher#3813
jasonsaayman merged 1 commit into
axios:masterfrom
anglinb:bump-sauce-labs

Conversation

@anglinb

@anglinb anglinb commented May 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I was unable to run the sauce labs tests on master so I tracked down some discussion here karma-runner/karma-sauce-launcher#230 (comment) and after testing locally, I believe this should make the sauce labs tests pass. Here are the errors I was seeing

25 05 2021 21:51:40.455:ERROR [SaucelabsLauncher]: Could not quit the Saucelabs selenium connection. Failure message:
25 05 2021 21:51:40.455:ERROR [SaucelabsLauncher]: TypeError: Cannot read property 'deleteSession' of undefined
    at SaucelabsLauncher.<anonymous> (/Users/brian/staffbar/axios/node_modules/karma-sauce-launcher/dist/launcher/launcher.js:149:26)
    at Generator.next (<anonymous>)
    at /Users/brian/staffbar/axios/node_modules/karma-sauce-launcher/dist/launcher/launcher.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/brian/staffbar/axios/node_modules/karma-sauce-launcher/dist/launcher/launcher.js:4:12)
    at SaucelabsLauncher.<anonymous> (/Users/brian/staffbar/axios/node_modules/karma-sauce-launcher/dist/launcher/launcher.js:141:31)
    at SaucelabsLauncher.emit (node:events:365:28)
    at SaucelabsLauncher.emit (node:domain:470:12)
    at SaucelabsLauncher.emitAsync (/Users/brian/staffbar/axios/node_modules/karma/lib/events.js:52:10)
    at SaucelabsLauncher.BaseLauncher.kill (/Users/brian/staffbar/axios/node_modules/karma/lib/launchers/base.js:61:27)
25 05 2021 21:51:40.455:ERROR [SaucelabsLauncher]: Could not quit the Saucelabs selenium connection. Failure message:
25 05 2021 21:51:40.455:ERROR [SaucelabsLauncher]: TypeError: Cannot read property 'deleteSession' of undefined

Screen Shot 2021-05-25 at 11 22 00 PM

jasonsaayman
jasonsaayman approved these changes May 27, 2021
View reviewed changes

@jasonsaayman jasonsaayman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks lets see if this helps 👍

@jasonsaayman jasonsaayman merged commit e9965bf into axios:master May 27, 2021
@anglinb

anglinb commented May 27, 2021

Copy link
Copy Markdown
Contributor Author

Well at least we have a new error 🙃 I pinged someone from Sauce Labs on the thread I referenced, we'll see if they have any ideas.

Here's where it failed 👇

2021-05-27T05:54:16.769Z ERROR webdriver: Request failed with status 500 due to Error: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/90f27026f00a4ae496f5ff7a435e8f28
2021-05-27T05:54:16.771Z ERROR webdriver: Error: Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/90f27026f00a4ae496f5ff7a435e8f28
    at Object.getErrorFromResponseBody (/home/travis/build/[secure]/[secure]/node_modules/webdriver/build/utils.js:94:12)
    at WebDriverRequest._request (/home/travis/build/[secure]/[secure]/node_modules/webdriver/build/request.js:134:31)
    at process._tickCallback (internal/process/next_tick.js:68:7)
27 05 2021 05:54:16.771:ERROR [SaucelabsLauncher]: Error: Failed to create session.
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/90f27026f00a4ae496f5ff7a435e8f28
    at Object.startWebDriverSession (/home/travis/build/[secure]/[secure]/node_modules/webdriver/build/utils.js:34:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Maybe a re-run might just make it work? Since it was a 500 response seems like a problem on their end (that could be transient 🤞 ).

This was referenced Sep 9, 2021
Merged
Closed
Closed
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
@anglinb
Fixing the sauce labs tests (axios#3813)
d70e242
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2022
Closed
This was referenced Oct 27, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonsaayman jasonsaayman jasonsaayman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anglinb @jasonsaayman