Switches where we check for invalid input, to move it inside the download function#127
Merged
Conversation
Contributor
|
LGTM @orta want to do it for 1-6-stable so I can ship 1.6.3? |
Member
Author
|
Hrm, tests passed locally, let's see what's up |
Contributor
|
I think it was just rubocop |
orta
force-pushed
the
validate_before_dl
branch
from
March 28, 2022 16:17
73d576b to
99fec61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While CocoaPods would have seen this issue, moves the check into the core path of using the cocoapods-download api. We're supposed to assume clients would not always run the pre-process API: