➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Py_INCREF(NULL) in _imp.create_builtin
Type: crash Stage: resolved
Components: Interpreter Core Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: rhettinger Nosy List: brett.cannon, eric.snow, ncoghlan, python-dev, rhettinger, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-08-31 09:26 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
create_builtin.patch xiang.zhang, 2016-08-31 09:26 review
Messages (3)
msg274007 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-08-31 09:26 
Just as the patch shows, when PyErr_Occurred() returns true mod is NULL, then Py_INCREF(mod) will crash. Replace it with Py_XINCREF.
msg274033 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-08-31 15:44 
New changeset caf547c9e589 by Raymond Hettinger in branch '3.5':
Issue #27909: Fix INCREF for possible NULL value
https://hg.python.org/cpython/rev/caf547c9e589
msg274034 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2016-08-31 15:45 
Thanks for the patch.
History
Date User Action Args
2022-04-11 14:58:35adminsetgithub: 72096
2016-08-31 16:02:51SilentGhostsetstage: resolved
2016-08-31 15:45:37rhettingersetstatus: open -> closed

nosy: + rhettinger
messages: + msg274034

assignee: rhettinger
resolution: fixed
2016-08-31 15:44:35python-devsetnosy: + python-dev
messages: + msg274033
2016-08-31 09:26:29xiang.zhangcreate